Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve query ops API, update deps #477

Merged
merged 11 commits into from
Sep 7, 2023
Merged

Improve query ops API, update deps #477

merged 11 commits into from
Sep 7, 2023

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Aug 29, 2023 •
edited
Loading

PR Type ([Feature | Fix | Documentation | Test])

Fix, Documentation. Addresses #473

Short Description

  • Fixes a bug in the way condition ops were joined using and/or
  • Removes use of metaclass and simply use abstract base class
  • Show example of using And in MIMICIV tutorial
  • Improve Sequential class in query operations module with things like addition, printing
  • Improve base QueryOp class
  • Fix notebooks to showcase new usage. Old way of passing list also works (so API doesn't break)
  • Update dependencies to newer versions.

Tests Added

...

@amrit110 amrit110 added bug Something isn't working documentation Improvements or additions to documentation labels Aug 29, 2023
@vaakesan-SMH vaakesan-SMH self-requested a review September 1, 2023 17:03
vaakesan-SMH
vaakesan-SMH approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@vaakesan-SMH vaakesan-SMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented this for the delirium_pipeline and tested results against raw SQL queries of the form (x LIKE ... OR x IN (...)) and confirmed that the results matched.

Great feature!

@amrit110 amrit110 added the refactor Refactor existing code, with same or similar functionality label Sep 5, 2023
@amrit110 amrit110 changed the title Fix bug in And/Or and also add example in tutorial Improve query ops API, update deps Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #477 (acab90a) into main (6ea5b5d) will decrease coverage by 0.22%.
The diff coverage is 71.61%.

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   58.32%   58.11%   -0.22%     
==========================================
  Files         105      105              
  Lines       10090    10282     +192     
==========================================
+ Hits         5885     5975      +90     
- Misses       4205     4307     +102
Files Changed Coverage Δ
cyclops/monitor/utils.py 36.15% <ø> (ø)
cyclops/query/interface.py 90.54% <ø> (ø)
cyclops/report/report.py 22.12% <ø> (ø)
cyclops/query/ops.py 78.11% <70.79%> (-9.12%) ⬇️
cyclops/query/util.py 91.79% <85.00%> (-0.30%) ⬇️
cyclops/evaluate/metrics/utils.py 78.57% <100.00%> (ø)

@amrit110 amrit110 merged commit 5b1c745 into main Sep 7, 2023
8 of 9 checks passed
@amrit110 amrit110 deleted the fix_and_or_add_example branch September 7, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaakesan-SMH vaakesan-SMH vaakesan-SMH approved these changes

Assignees

@a-kore a-kore

Labels
bug Something isn't working documentation Improvements or additions to documentation refactor Refactor existing code, with same or similar functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrit110 @vaakesan-SMH @a-kore